Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706150

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

From SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups linux.kernel
Subject Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
Date 2017-08-08 10:30 +0200
Message-ID <uc83M-5ix-9@gated-at.bofh.it> (permalink)
References (3 earlier) <ubUWS-3Xj-25@gated-at.bofh.it> <ubV6y-416-9@gated-at.bofh.it> <ubVgd-45a-1@gated-at.bofh.it> <ubVzB-4s8-39@gated-at.bofh.it> <ubWFj-5gn-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>> https://patchwork.ozlabs.org/patch/798575/
> 
> I submitted your patch

Thanks for your constructive feedback.
https://patchwork.ozlabs.org/patch/798850/


> and a fix to ps3vram_probe() with the other patches in my queue.

I find it nice that you picked this change opportunity up after
a bit of discussion (before an other developer would eventually
have tackled it also).

“Check return of ps3vram_cache_init”
https://patchwork.ozlabs.org/patch/798853/

1. Unfortunately, I find that this specific update suggestion does not fit
   to the Linux coding style convention.

   “…
   Do not unnecessarily use braces where a single statement will do.
   …”

2. How do you think about to use the check “if (error)” instead?

3. Will an additional commit description be useful?

Regards,
Markus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 13:00 +0200
  Re: [PATCH] block/ps3vram: Delete an error message for a failed  memory allocation in ps3vram_cache_init() Joe Perches <joe@perches.com> - 2017-08-07 17:20 +0200
  Re: [PATCH] block/ps3vram: Delete an error message for a failed  memory allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 17:20 +0200
    Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 18:30 +0200
      Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 20:30 +0200
        Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 20:40 +0200
          Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 20:50 +0200
            Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 21:10 +0200
              Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 22:20 +0200
                Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-08 10:30 +0200
              Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() Michael Ellerman <mpe@ellerman.id.au> - 2017-08-08 04:20 +0200

csiph-web