Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1704854
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] mtd: physmap_of: Fix resources leak in 'of_flash_probe()' |
| Date | 2017-08-06 16:10 +0200 |
| Message-ID | <ubupJ-3f0-37@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
If 'of_flash_probe_gemini()' or 'of_flash_probe_versatile()' fail, we must reslease some resources, as already done in all error handling paths in this function. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/mtd/maps/physmap_of_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c index 62fa6836f218..2c8cc97ce019 100644 --- a/drivers/mtd/maps/physmap_of_core.c +++ b/drivers/mtd/maps/physmap_of_core.c @@ -235,10 +235,10 @@ static int of_flash_probe(struct platform_device *dev) err = of_flash_probe_gemini(dev, dp, &info->list[i].map); if (err) - return err; + goto err_out; err = of_flash_probe_versatile(dev, dp, &info->list[i].map); if (err) - return err; + goto err_out; err = -ENOMEM; info->list[i].map.virt = ioremap(info->list[i].map.phys, -- 2.11.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH] mtd: physmap_of: Fix resources leak in 'of_flash_probe()' Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-08-06 16:10 +0200
csiph-web