Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1705632

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

Show all headers | View raw

On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 7 Aug 2017 12:37:01 +0200
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.

NACK

When a user asks me for help I would certainly like to get 
'Could not allocate cache tags' as apposed to nothing, since
the return value of ps3vram_cache_init() is not checked.

If you want to make an improvement please add a check for
success of ps3vram_cache_init() in ps3vram_probe().

-Geoff

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 13:00 +0200
  Re: [PATCH] block/ps3vram: Delete an error message for a failed  memory allocation in ps3vram_cache_init() Joe Perches <joe@perches.com> - 2017-08-07 17:20 +0200
  Re: [PATCH] block/ps3vram: Delete an error message for a failed  memory allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 17:20 +0200
    Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 18:30 +0200
      Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 20:30 +0200
        Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 20:40 +0200
          Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 20:50 +0200
            Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-07 21:10 +0200
              Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() Geoff Levand <geoff@infradead.org> - 2017-08-07 22:20 +0200
                Re: block/ps3vram: Delete an error message for a failed memory  allocation in ps3vram_cache_init() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-08 10:30 +0200
              Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() Michael Ellerman <mpe@ellerman.id.au> - 2017-08-08 04:20 +0200

csiph-web