Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
Date	2017-08-07 15:00 +0200
Message-ID	<ubPNx-8kD-23@gated-at.bofh.it> (permalink)
References	<uawMV-6qt-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 4, 2017 at 12:00 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:

> platform_get_irq() returns an error code, but the gpio-msic driver
> ignores it and always returns -EINVAL. This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly.
>
> Notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
>
> Print and propagate the return value of platform_get_irq on failure.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Patch applied.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] gpio: msic: fix error return code in  platform_msic_gpio_probe() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-04 00:30 +0200
  Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe() Linus Walleij <linus.walleij@linaro.org> - 2017-08-07 15:00 +0200

csiph-web