[PATCH 2/2] mmc: sunxi: fix new timings mode on A64 EMMC (MMC2) controller

From	Icenowy Zheng <icenowy@aosc.io>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] mmc: sunxi: fix new timings mode on A64 EMMC (MMC2) controller
Date	2017-08-04 23:40 +0200
Message-ID	<uaSu6-40A-3@gated-at.bofh.it> (permalink)
References	<uaSu6-40A-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The configuration struct of A64 EMMC(MMC2) compatible used to
have the needs_new_timings variable missing, which lead to NULL
pointer dereference now when trying to set up the old timings mode, as
the old timings mode doesn't exist at all on A64.

Fix this issue by adding this variable and setting it to true in
the configuration struct.

Fixes: 4fb3ce07eafa ("mmc: sunxi: Add EMMC (MMC2) controller compatible")

Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/mmc/host/sunxi-mmc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 59aba93beffb..4ad643e37014 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -1142,6 +1142,7 @@ static const struct sunxi_mmc_cfg sun50i_a64_emmc_cfg = {
 	.idma_des_size_bits = 13,
 	.clk_delays = NULL,
 	.can_calibrate = true,
+	.needs_new_timings = true,
 };
 
 static const struct of_device_id sunxi_mmc_of_match[] = {
-- 
2.13.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mmc: sunxi: fix new timings mode on A64 EMMC (MMC2) controller Icenowy Zheng <icenowy@aosc.io> - 2017-08-04 23:40 +0200
  Re: [linux-sunxi] [PATCH 2/2] mmc: sunxi: fix new timings mode on  A64 EMMC (MMC2) controller Chen-Yu Tsai <wens@csie.org> - 2017-08-06 04:50 +0200
    Re: [linux-sunxi] [PATCH 2/2] mmc: sunxi: fix new timings mode on A64 EMMC (MMC2) controller Icenowy Zheng <icenowy@aosc.io> - 2017-08-06 05:30 +0200
    Re: [linux-sunxi] [PATCH 2/2] mmc: sunxi: fix new timings mode on A64  EMMC (MMC2) controller icenowy@aosc.io - 2017-08-07 09:00 +0200

csiph-web