Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1703853

Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible

Show all headers | View raw

On 2017-08-04 12:10, Mika Westerberg wrote:
> On Thu, Aug 03, 2017 at 01:40:32PM +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> We still need to request/free GPIOs passed via the legacy path of
>> pxa2xx_spi_chip::gpio_cs, but we can use the gpiod API otherwise.
>>
>> Consistently use the descriptor API instead of the legacy one.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> There are some PXA2xx platforms under arch/arm/* which use this driver
> and legacy GPIOs. I wonder if this causes any problems with them?
> 
> That was one of the reasons I did not convert the whole driver over GPIO
> descriptors.

It shouldn't cause problems (famous last words) because I refrained from
changing the interfaces to them. References that come in as legacy GPIO
are still treated like that.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 0/2] spi: pxa2xx: gpiod cleanups and late CS GPIO allocation Jan Kiszka <jan.kiszka@siemens.com> - 2017-08-03 13:50 +0200
  [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where possible Jan Kiszka <jan.kiszka@siemens.com> - 2017-08-03 13:50 +0200
    Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API  where possible Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-04 12:20 +0200
      Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API where  possible Jan Kiszka <jan.kiszka@siemens.com> - 2017-08-04 12:20 +0200
        Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API  where possible Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-04 12:30 +0200
          Re: [PATCH RFC 1/2] spi: pxa2xx: Convert to GPIO descriptor API  where possible Mark Brown <broonie@kernel.org> - 2017-08-04 13:50 +0200
    Applied "spi: pxa2xx: Convert to GPIO descriptor API where possible" to the spi tree Mark Brown <broonie@kernel.org> - 2017-08-04 13:50 +0200
  [PATCH RFC 2/2] spi: pxa2xx: Only claim CS GPIOs when the slave device is created Jan Kiszka <jan.kiszka@siemens.com> - 2017-08-03 13:50 +0200
    Re: [PATCH RFC 2/2] spi: pxa2xx: Only claim CS GPIOs when the slave  device is created Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-08-04 12:30 +0200
    Re: [PATCH RFC 2/2] spi: pxa2xx: Only claim CS GPIOs when the slave  device is created Mark Brown <broonie@kernel.org> - 2017-08-04 13:50 +0200

csiph-web