Re: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode

From	Jernej Škrabec <jernej.skrabec@siol.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode
Date	2017-07-31 19:20 +0200
Message-ID	<u9mwi-Ac-25@gated-at.bofh.it> (permalink)
References	<u8ZzH-2LG-3@gated-at.bofh.it> <u8ZzI-2LG-9@gated-at.bofh.it> <u9b7P-22o-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Chen-Yu,

Dne ponedeljek, 31. julij 2017 ob 07:02:18 CEST je Chen-Yu Tsai napisal(a):
> On Mon, Jul 31, 2017 at 12:41 AM, Jernej Skrabec
> 
> <jernej.skrabec@siol.net> wrote:
> > Currently ccu_frac_helper_set_rate() doesn't wait for a lock bit to be
> > set before returning. Because of that, unstable clock may be used.
> > 
> > Add a wait for lock in the helper function.
> > 
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> 
> Can you provide a Fixes: tag?

fixes: 89a3dfb78707 ("clk: sunxi-ng: Add fractional lib")

As we discussed on IRC, it is safe to call ccu_helper_wait_for_lock() even on 
platforms where lock bit is not present, since it just returns without effect.

Regards,
Jernej

> 
> Otherwise this looks good.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode Jernej Skrabec <jernej.skrabec@siol.net> - 2017-07-30 18:50 +0200
  Re: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode Chen-Yu Tsai <wens@csie.org> - 2017-07-31 07:10 +0200
    Re: [PATCH 4/4] clk: sunxi-ng: Wait for lock when using fractional mode Jernej Škrabec <jernej.skrabec@siol.net> - 2017-07-31 19:20 +0200

csiph-web