Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

From	Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver
Date	2017-08-01 11:40 +0200
Message-ID	<u9BOG-1MA-19@gated-at.bofh.it> (permalink)
References	(2 earlier) <u5WoG-6X1-23@gated-at.bofh.it> <u6M3T-5Cy-1@gated-at.bofh.it> <u7n3r-4zl-1@gated-at.bofh.it> <u7p5f-5Ol-9@gated-at.bofh.it> <u9hZF-6eS-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 07/31/2017 02:31 PM, Vinod Koul wrote:
> On Wed, Jul 26, 2017 at 07:38:02AM +0000, Pierre Yves MORDRET wrote:
>>>>>> +
>>>>>> +#ifndef __DMA_STM32_DMAMUX_H
>>>>>> +#define __DMA_STM32_DMAMUX_H
>>>>>> +
>>>>>> +#if defined(CONFIG_STM32_DMAMUX)
>>>>>> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id);
>>>>>
>>>>> Why do we need a custom API in this case?
>>>>>
>>>>
>>>> This API is called by DMA when a slave is requested by client. DMA can work
>>>> without DMAMUX this API has been put in place to configure DMAMUX whether client
>>>> is requesting a DMAMUX Channel instead of a DMA one.
>>>
>>> You mean the dmaengine driver right?
>>>
>>
>> Yes. The API is mainly called by "device_config" through out STM32 DMA Driver
>> when a router is in place for client.
>> Please refer to Patch 4/5 on this set.
> 
> Okay am thinking on why this can't be generic..? An optional router config
> callback?
> 

I would have liked to answer there is a callback within engine but unfortunately
I didn't figure out one when I did my router's development. I've looked once
more but again I can't find how to map chanID and request line without custom API.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-08-01 11:40 +0200
  Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Vinod Koul <vinod.koul@intel.com> - 2017-08-02 07:00 +0200
    Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-08-02 11:30 +0200
      Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-08-02 15:20 +0200
        Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-08-02 16:20 +0200
          Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-08-02 16:30 +0200
            Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-08-03 08:50 +0200
              Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-08-03 11:10 +0200
                Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-08-03 12:00 +0200
                Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Pierre Yves MORDRET <pierre-yves.mordret@st.com> - 2017-08-04 15:00 +0200
                Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver Peter Ujfalusi <peter.ujfalusi@ti.com> - 2017-08-04 16:30 +0200

csiph-web