Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1699289

[PATCH 3/6] net: moxa: Fix comparison to NULL could be written with !

Show all headers | View raw

Fixed coding style for null comparisons in moxart_ether driver
to be more consistent with the rest of the kernel coding style

Signed-off-by: SZ Lin <sz.lin@moxa.com>
---
 drivers/net/ethernet/moxa/moxart_ether.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c
index 9997e72103d5..1d6384873393 100644
--- a/drivers/net/ethernet/moxa/moxart_ether.c
+++ b/drivers/net/ethernet/moxa/moxart_ether.c
@@ -494,7 +494,7 @@ static int moxart_mac_probe(struct platform_device *pdev)
 	priv->tx_desc_base = dma_alloc_coherent(NULL, TX_REG_DESC_SIZE *
 						TX_DESC_NUM, &priv->tx_base,
 						GFP_DMA | GFP_KERNEL);
-	if (priv->tx_desc_base == NULL) {
+	if (!priv->tx_desc_base) {
 		ret = -ENOMEM;
 		goto init_fail;
 	}
@@ -502,7 +502,7 @@ static int moxart_mac_probe(struct platform_device *pdev)
 	priv->rx_desc_base = dma_alloc_coherent(NULL, RX_REG_DESC_SIZE *
 						RX_DESC_NUM, &priv->rx_base,
 						GFP_DMA | GFP_KERNEL);
-	if (priv->rx_desc_base == NULL) {
+	if (!priv->rx_desc_base) {
 		ret = -ENOMEM;
 		goto init_fail;
 	}
-- 
2.13.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] net: moxa: Fix style issues SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 2/6] net: moxa: Prefer 'unsigned int' to bare use of 'unsigned' SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 3/6] net: moxa: Fix comparison to NULL could be written with ! SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 5/6] net: moxa: Fix for typo in comment to function moxart_mac_setup_desc_ring() SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 4/6] net: moxa: Remove extra space after a cast SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 1/6] net: moxa: Remove braces from single-line body SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  [PATCH 6/6] net: moxa: Add spaces preferred around that '{+,-}' SZ Lin <sz.lin@moxa.com> - 2017-07-29 12:50 +0200
  Re: [PATCH 0/6] net: moxa: Fix style issues David Miller <davem@davemloft.net> - 2017-07-29 23:10 +0200

csiph-web