Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.c++ > #90789

Re: What Does this program ?

From Bonita Montero <Bonita.Montero@gmail.com>
Newsgroups comp.lang.c++
Subject Re: What Does this program ?
Date 2023-06-30 13:10 +0200
Organization A noiseless patient Spider
Message-ID <u7md6e$2h93r$1@dont-email.me> (permalink)
References <u7k6qh$26elc$1@dont-email.me> <u7k8s5$26l5b$1@dont-email.me> <u7k9p4$26nls$1@dont-email.me> <NArnM.367$edN3.188@fx14.iad>

Show all headers | View raw


Am 30.06.2023 um 05:02 schrieb Pavel:

> Why to hardcode dots? Some use commas, some prefer underscores, some 
> spaces...

That's just a detail. For my purpose dots are sufficient.

> Why to hardcode 3?

Because the groups will never be different.

> Why so many copies?

Because the row of / 10 calculations would be done only once.

> Why unhelpful names?

That's a matter of taste.

> Why a single function for at least two distinct jobs?

The function is for one jjob.

> Why no braces -- is this to make maintenance as error-prone as possible?

I don't make errors at this level-

> Why do I still have to read the code like this ???????
> It's no longer  1983! (cries and hits his head against his monitor)

  My code is sexy for me.

This is the completed version:

#pragma once
#include <string_view>
#include <concepts>
#include <type_traits>
#include <array>

template<std::integral CharType, std::integral ValueType>
std::basic_string_view<CharType> dottifySv( ValueType value )
{
	using namespace std;
	static_assert(sizeof(ValueType) <= 8, "");
	using uvalue_t = make_unsigned_t<ValueType>;
	uvalue_t uValue;
	if constexpr( signed_integral<ValueType> )
		uValue = value >= 0 ? value : -value;
	else
		uValue = value;
	using dig_arr_t = array<uint8_t, 20>; // max 20 digits for 64 bit
	using dig_arr_it = dig_arr_t::iterator;
	dig_arr_t reverseDigits;
	dig_arr_it rDigitsEnd = reverseDigits.begin();
	do
		*rDigitsEnd++ = uValue % 10,
		uValue /= 10;
	while( uValue );
	size_t groups = (rDigitsEnd - reverseDigits.begin() - 1) / 3;
	using str_arr_t = array<CharType, 1 + 20 + (20 - 1) / 3>;
	using str_arr_it = str_arr_t::iterator;
	thread_local str_arr_t retArr;
	str_arr_it wrt = retArr.end();
	dig_arr_it digit = reverseDigits.begin();
	auto append = [&]() { *--wrt = *digit++ + '0'; };
	for( dig_arr_it groupsEnd = reverseDigits.begin() + groups * 3; digit 
!= groupsEnd; wrt -= 4, digit += 3 )
		append(),
		append(),
		append(),
		*--wrt = '.';
	do
		append();
	while( digit != rDigitsEnd );
	if constexpr( signed_integral<ValueType> )
		if( value < 0 )
			*--wrt = '-';
	return basic_string_view<CharType>( wrt, retArr.end() );
}

template<std::integral CharType, std::integral ValueType>
std::basic_string<CharType> dottify( ValueType value )
{
	using namespace std;
	basic_string_view<CharType> sv( dottifySv<CharType>( value ) );
	return basic_string<CharType>( sv.begin(), sv.end() );
}

Back to comp.lang.c++ | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-06-29 17:09 +0200
  Re: What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-06-29 17:44 +0200
    Re: What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-06-29 17:59 +0200
      Re: What Does this program ? Pavel <pauldontspamtolk@removeyourself.dontspam.yahoo> - 2023-06-29 23:02 -0400
        Re: What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-06-30 13:10 +0200
          Re: What Does this program ? "Chris M. Thomasson" <chris.m.thomasson.1@gmail.com> - 2023-06-30 09:59 -0700
            Re: What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-06-30 19:03 +0200
              Re: What Does this program ? "Chris M. Thomasson" <chris.m.thomasson.1@gmail.com> - 2023-06-30 10:07 -0700
        Re: What Does this program ? scott@slp53.sl.home (Scott Lurndal) - 2023-06-30 13:38 +0000
    Re: What Does this program ? David Brown <david.brown@hesbynett.no> - 2023-07-03 14:58 +0200
      Re: What Does this program ? Bonita Montero <Bonita.Montero@gmail.com> - 2023-07-04 08:28 +0200

csiph-web