Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1698240

Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask

Show all headers | View raw

On Thu, Jul 27, 2017 at 01:15:48PM -0500, Michael Bringmann wrote:
> 
> On NUMA systems with dynamic processors, the content of the cpumask
> may change over time.  As new processors are added via DLPAR operations,
> workqueues are created for them.  Depending upon the order in which CPUs
> are added/removed, we may run into problems with the content of the
> cpumask used by the workqueues.  This patch deals with situations where
> the online cpumask for a node is a proper superset of possible cpumask
> for the node.  It also deals with edge cases where the order in which
> CPUs are removed/added from the online cpumask may leave the set for a
> node empty, and require execution by CPUs on another node.
> 
> In these and other cases, the patch attempts to ensure that a valid,
> usable cpumask is used to set up newly created pools for workqueues.
> This patch provides a fix for NUMA systems which can add/subtract
> processors dynamically.  The patch is expected to be an intermediate
> one while developers search for any underlying issues.

Please start with describing what the underlying problem is - CPU <->
NUMA node mapping change on powerpc.  The mapping shouldn't change,
not just for workqueue, but because we don't have any kind of
synchronization around the mapping throughout allocation paths.  And
then, please describe how this patch can at least prevent immediate
crashes in a lot of cases.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-07-27 20:20 +0200
  Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Tejun Heo <tj@kernel.org> - 2017-07-27 20:40 +0200
    Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-07-27 21:10 +0200
      Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Tejun Heo <tj@kernel.org> - 2017-07-27 21:30 +0200
        Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-07-27 22:20 +0200
          Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Tejun Heo <tj@kernel.org> - 2017-07-27 22:50 +0200
  Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Nathan Fontenot <nfont@linux.vnet.ibm.com> - 2017-07-27 20:50 +0200
    Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Michael Bringmann <mwb@linux.vnet.ibm.com> - 2017-07-27 21:20 +0200
      Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask Tejun Heo <tj@kernel.org> - 2017-07-27 21:30 +0200

csiph-web