Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight binding

From	Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight binding
Date	2017-07-27 12:30 +0200
Message-ID	<u7Odj-4Tl-1@gated-at.bofh.it> (permalink)
References	<u4ezn-5Kj-11@gated-at.bofh.it> <u4ezn-5Kj-9@gated-at.bofh.it> <u6OS5-7yA-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Jul 24, 2017 at 11:58:26AM -0500, Rob Herring wrote:
> On Mon, Jul 17, 2017 at 03:39:55PM +0200, Sebastian Reichel wrote:
> > +Required property:
> > + - compatible: Should be one of:
> > +        "ti,lm3532-backlight"
> > +        "ti,lm3631-backlight"
> > +        "ti,lm3632-backlight"
> > +        "ti,lm3633-backlight"
> > +        "ti,lm3695-backlight"
> > +        "ti,lm3697-backlight"
> 
> Some of the parts only do backlight, so drop the "-backlight" on those. 
> And having a sub-node makes no sense in that case. Perhaps it should be 
> 2 binding documents separating the single function devices and MFDs. The 
> binding doc(s) doesn't have to align with the driver(s). You can have 1 
> driver serve 2 bindings.

Yes, there is LM3532 and LM3695, which is backlight only as far as I
can see. Your suggestion contradicts with existing binding, though:

Documentation/devicetree/bindings/mfd/ti-lmu.txt

-- Sebastian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight  binding Rob Herring <robh@kernel.org> - 2017-07-24 19:00 +0200
  Re: [PATCHv2 1/2] dt-bindings: backlight: add ti-lmu-backlight  binding Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-07-27 12:30 +0200

csiph-web