Re: [PATCH 2/3] sparc64: Add 16GB hugepage support

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] sparc64: Add 16GB hugepage support
Date	2017-07-26 22:20 +0200
Message-ID	<u7AWK-4Xd-9@gated-at.bofh.it> (permalink)
References	<u2Ujn-2Cp-13@gated-at.bofh.it> <u5pVM-3D7-17@gated-at.bofh.it> <u7znX-3Tc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Nitin Gupta <nitin.m.gupta@oracle.com>
Date: Wed, 26 Jul 2017 11:35:28 -0700

> 
> 
> On 07/20/2017 01:04 PM, David Miller wrote:
>> From: Nitin Gupta <nitin.m.gupta@oracle.com>
>> Date: Thu, 13 Jul 2017 14:53:24 -0700
>> 
>>> Testing:
>>>
>>> Tested with the stream benchmark which allocates 48G of
>>> arrays backed by 16G hugepages and does RW operation on
>>> them in parallel.
>> 
>> It would be great if we started adding tests under
>> tools/testing/selftests so that other people can recreate
>> your tests/benchmarks.
>> 
> 
> Yes, I would like to add the stream benchmark to selftests too.
> I will check if our internal version of stream can be released.

That would be great.

>> This macro is getting way out of control, every TLB/TSB miss is
>> going to invoke this sequence of code.
>> 
>> Yes, it's just a two cycle constant load, a test modifying the
>> condition codes, and an easy to predict branch.
>> 
>> But every machine will eat this overhead, even if they don't use
>> hugepages or don't set the 16GB knob.
>> 
>> I think we can do better, using code patching or similar.
>> 
>> Once the knob is set, you can know for sure that this code path
>> will never actually be taken.
> 
> The simplest way I can think of is to add CONFIG_SPARC_16GB_HUGEPAGE
> and exclude PUD check if not enabled.  Would this be okay?

I am saying above to do a run-time code patch.

Kconfig knobs are completely pointless in this kind of situation
since every distribution is going to turn the thing on so essentially
all real users eat the overhead if you do it the Kconfig way.

So do a run-time code patch instead, thank you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] sparc64: Add 16GB hugepage support David Miller <davem@davemloft.net> - 2017-07-20 22:10 +0200
  Re: [PATCH 2/3] sparc64: Add 16GB hugepage support Nitin Gupta <nitin.m.gupta@oracle.com> - 2017-07-26 20:40 +0200
    Re: [PATCH 2/3] sparc64: Add 16GB hugepage support David Miller <davem@davemloft.net> - 2017-07-26 22:20 +0200

csiph-web