Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1695646

Re: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 21, 2017 at 09:19:02AM -0400, Sven Van Asbroeck wrote:
> The function
> static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep)
> takes the chip in and out of sleep mode, depending on the value of
> sleep, which is interpreted as a boolean.
> 
> To clarify that 'int sleep' is a boolean and not a sleep delay,
> change the function interface to:
> static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable)
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
> ---
>  drivers/pwm/pwm-pca9685.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Applied, thanks.

Thierry

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode()  interface. Thierry Reding <thierry.reding@gmail.com> - 2017-07-25 13:50 +0200

csiph-web