Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1694174

Re: [PATCH] Staging: lustre: Place the open brace on previous line.

Show all headers | View raw

On Sat, 2017-07-22 at 22:26 +0530, Shreeya Patel wrote:
> Remove errors by placing the open braces on previous line.
> This saves the vertical space of the code.
> 
> Problem found by checkpatch.

No.  These are checkpatch false positives.

> diff --git a/drivers/staging/lustre/lnet/libcfs/hash.c b/drivers/staging/lustre/lnet/libcfs/hash.c
[]
> @@ -1348,8 +1348,7 @@ cfs_hash_lookup(struct cfs_hash *hs, const void *key)
>  EXPORT_SYMBOL(cfs_hash_lookup);
>  
>  static void
> -cfs_hash_for_each_enter(struct cfs_hash *hs)
> -{
> +cfs_hash_for_each_enter(struct cfs_hash *hs) {
>  	LASSERT(!cfs_hash_is_exiting(hs));
>  
>  	if (!cfs_hash_with_rehash(hs))

etc...

These are correctly written function definitions.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: lustre: Place the open brace on previous line. Shreeya Patel <shreeya.patel23498@gmail.com> - 2017-07-22 19:00 +0200
  Re: [PATCH] Staging: lustre: Place the open brace on previous line. Joe Perches <joe@perches.com> - 2017-07-22 19:10 +0200

csiph-web