Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
Date	2017-07-18 09:30 +0200
Message-ID	<u4v7c-7Sa-3@gated-at.bofh.it> (permalink)
References	<tYcTE-2XI-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)

I've had to drop this from my tree due to the obvious build warning it
adds to the system.  Always test-build your patches before sending them
out, it makes maintainers grumpy when you do not do that :(

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] serial: 8250: fix error handling in  of_platform_serial_probe() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 09:30 +0200
  Re: [PATCH] serial: 8250: fix error handling in  of_platform_serial_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-07-18 09:40 +0200
    [PATCH v2] serial: 8250: fix error handling in of_platform_serial_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-07-18 13:40 +0200
      Re: [PATCH v2] serial: 8250: fix error handling in of_platform_serial_probe() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-18 17:10 +0200
      Re: [PATCH v2] serial: 8250: fix error handling in  of_platform_serial_probe() Johan Hovold <johan@kernel.org> - 2017-07-18 17:50 +0200
        Re: [PATCH v2] serial: 8250: fix error handling in of_platform_serial_probe() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-18 18:00 +0200
        [PATCH v3] serial: 8250: fix error handling in of_platform_serial_probe() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2017-07-19 10:40 +0200

csiph-web