Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689504

Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased)

Show all headers | View raw

On Thu, Jul 13, 2017 at 09:26:50PM +0200, Philipp wrote:
> 
> > On 13. Jul 2017, at 17:45, Sakari Ailus <sakari.ailus@iki.fi> wrote:
> > 
> > On Thu, Jul 13, 2017 at 08:55:43AM +0200, Philipp Guendisch wrote:
> >> This patch fixed code alignment to open paranthesis.
> >> Semantic should not be affected by this patch.
> >> 
> >> It has been rebased on top of media_tree atomisp branch
> >> 
> >> Signed-off-by: Philipp Guendisch <philipp.guendisch@fau.de>
> >> Signed-off-by: Chris Baller <chris.baller@gmx.de>
> > 
> > Hi Philipp,
> > 
> > Neither of the patches still applies?
> > 
> > Are you sure you rebased them on the atomisp branch?
> > 
> > -- 
> > Regards,
> > 
> > Sakari Ailus
> > e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk
> 
> Hi Ailus,
> 
> Unfortunately I dont know exactly why the patches did not apply.
> 
> I tried a rebase with:
> 
> "git remote add sailus-mediatree git://linuxtv.org/sailus/media_tree.git <git://linuxtv.org/sailus/media_tree.git>
> git fetch sailus-mediatree
> git checkout atomisp”
> 
> Maybe I took too much time for rebasing and some patches were accepted between my ‘git pull’ and 'git send-email'
> 
> I did another git pull right now and have seen the pathches are already in the commit history.
> 
> So I think it's time to give you a huge THANK YOU!

You're welcome, and thank you for the cleanup patches!

This was my mistake actually; I thought the patches didn't apply but I
ended up trying to apply them... twice. That's what you get when you have
too many atomisp patches. :-o

> 
> If I got it wrong and threre is still some work to do for the two patches please let me know 
> and I will try to fix it.
> 
> PS: I am totally new to kernel development yet.

Cleanup patches are a really good way to start, besides fixing small issues
here and there. :-)

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: atomisp2: hmm: Fixed comment style Philipp Guendisch <philipp.guendisch@fau.de> - 2017-07-10 21:00 +0200
  Re: [PATCH 1/2] staging: atomisp2: hmm: Fixed comment style Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-11 17:30 +0200
    [PATCH v2 1/2] staging: atomisp2: hmm: Fixed comment style Philipp Guendisch <philipp.guendisch@fau.de> - 2017-07-13 09:00 +0200
      [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased) Philipp Guendisch <philipp.guendisch@fau.de> - 2017-07-13 09:00 +0200
        Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased) Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-13 18:00 +0200
          Re: [PATCH v2 2/2] staging: atomisp2: hmm: Alignment code (rebased) Sakari Ailus <sakari.ailus@iki.fi> - 2017-07-17 23:40 +0200

csiph-web