Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689246

Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Enric,

On Mon, Jul 17, 2017 at 12:30:30PM +0200, Enric Balletbo Serra wrote:
> Hi Gwendal,
> 
> Interesting I didn't know that. So are you saying that this patch will
> break support for devices like Pixel 2? I tested the patches on
> various devices but not on Pixel 2 so could be.

This would affect any systems where we have chained ECs. Samus (Chromebook
Pixel 2015) has its PD EC hooked up in this way. Practically speaking,
that would mean that the cros_usbpd-charger power supply driver may not work
correctly.

I don't think we expect any other systems to have this configuration,
but the first one we shipped did, so we will have to support it.

Thanks,
Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features from cros_ec_dev. Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-07-12 12:20 +0200
  Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features  from cros_ec_dev. Gwendal Grignou <gwendal@chromium.org> - 2017-07-13 22:40 +0200
    Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features  from cros_ec_dev. Enric Balletbo Serra <eballetbo@gmail.com> - 2017-07-17 12:40 +0200
      Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features  from cros_ec_dev. Benson Leung <bleung@google.com> - 2017-07-17 18:40 +0200
      Re: [PATCH v3 1/4] mfd: cros_ec: Get rid of cros_ec_check_features  from cros_ec_dev. Lee Jones <lee.jones@linaro.org> - 2017-07-18 11:20 +0200

csiph-web