Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1690552

Re: [PATCH 1/7] signal/alpha: Document a conflict with SI_USER for SIGTRAP

Show all headers | View raw

On 07/18/2017 04:06 AM, Eric W. Biederman wrote:
> Setting si_code to __SI_FAULT results in a userspace seeing
> an si_code of 0.  This is the same si_code as SI_USER.  Posix
> and common sense requires that SI_USER not be a signal specific
> si_code.  As such this use of 0 for the si_code is a pretty
> horribly broken ABI.
> 
> Given that alpha is on it's last legs I don't know that it is worth
> fixing this, but it is worth documenting what is going on so that
> no one decides to copy this bad decision.
> 
> This was introduced during the 2.5 development cycle so this
> mess has had a long time for people to be able to depend upon it.
> 
> v2: Added FPE_FIXME for alpha as Helge Deller<deller@gmx.de>  pointed out
>      with his alternate patch one of the cases is SIGFPE not SIGTRAP.
> 
> Cc: Helge Deller<deller@gmx.de>
> Cc: Richard Henderson<rth@twiddle.net>
> Cc: Ivan Kokshaysky<ink@jurassic.park.msu.ru>
> Cc: Matt Turner<mattst88@gmail.com>
> Cc:linux-alpha@vger.kernel.org
> History Tree:https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git
> Ref: 0a635c7a84cf ("Fill in siginfo_t.")
> Signed-off-by: "Eric W. Biederman"<ebiederm@xmission.com>
> ---
>   arch/alpha/include/uapi/asm/siginfo.h | 14 ++++++++++++++
>   arch/alpha/kernel/traps.c             |  6 +++---
>   2 files changed, 17 insertions(+), 3 deletions(-)

Acked-by: Richard Henderson <rth@twiddle.net>


r~

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] signal: Fix sending signals with siginfo ebiederm@xmission.com (Eric W. Biederman) - 2017-07-18 16:20 +0200
  [PATCH 6/7] fcntl: Don't use ambiguous SIG_POLL si_codes "Eric W. Biederman" <ebiederm@xmission.com> - 2017-07-18 16:20 +0200
    Re: [PATCH 6/7] fcntl: Don't use ambiguous SIG_POLL si_codes Oleg Nesterov <oleg@redhat.com> - 2017-07-20 18:20 +0200
      Re: [PATCH 6/7] fcntl: Don't use ambiguous SIG_POLL si_codes ebiederm@xmission.com (Eric W. Biederman) - 2017-07-21 04:50 +0200
  [PATCH 4/7] signal/mips: Document a conflict with SI_USER with SIGFPE "Eric W. Biederman" <ebiederm@xmission.com> - 2017-07-18 16:20 +0200
  [PATCH 3/7] signal/sparc: Document a conflict with SI_USER with SIGFPE "Eric W. Biederman" <ebiederm@xmission.com> - 2017-07-18 16:20 +0200
  [PATCH 1/7] signal/alpha: Document a conflict with SI_USER for SIGTRAP "Eric W. Biederman" <ebiederm@xmission.com> - 2017-07-18 16:20 +0200
    Re: [PATCH 1/7] signal/alpha: Document a conflict with SI_USER for  SIGTRAP Richard Henderson <rth@twiddle.net> - 2017-07-18 20:30 +0200
  Re: [PATCH 7/7] signal: Remove kernel interal si_code magic Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-18 19:00 +0200
    Re: [PATCH 7/7] signal: Remove kernel interal si_code magic ebiederm@xmission.com (Eric W. Biederman) - 2017-07-18 19:40 +0200
      Simplfying copy_siginfo_to_user ebiederm@xmission.com (Eric W. Biederman) - 2017-07-22 22:40 +0200
        Re: Simplfying copy_siginfo_to_user Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-24 19:50 +0200
          Re: Simplfying copy_siginfo_to_user ebiederm@xmission.com (Eric W. Biederman) - 2017-07-24 21:20 +0200
          Re: Simplfying copy_siginfo_to_user Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-25 03:40 +0200

csiph-web