Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol
Date	2017-07-18 18:50 +0200
Message-ID	<u4DR8-4Ny-9@gated-at.bofh.it> (permalink)
References	<u4epI-5H0-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/17/2017 06:39 AM, Geert Uytterhoeven wrote:
> All low-level PM/SMP code using virt_to_phys() should actually use
> __pa_symbol() against kernel symbols.  Update the documentation to move
> away from virt_to_phys().
> 
> Cfr. commit 6996cbb2372189f7 ("ARM: 8641/1: treewide: Replace uses of
> virt_to_phys with __pa_symbol")
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>

Sorry for not noticing earlier.

> ---
>  Documentation/arm/firmware.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/arm/firmware.txt b/Documentation/arm/firmware.txt
> index da6713adac8acffc..7f175dbb427e631a 100644
> --- a/Documentation/arm/firmware.txt
> +++ b/Documentation/arm/firmware.txt
> @@ -60,7 +60,7 @@ Example of using a firmware operation:
>  
>  	/* some platform code, e.g. SMP initialization */
>  
> -	__raw_writel(virt_to_phys(exynos4_secondary_startup),
> +	__raw_writel(__pa_symbol(exynos4_secondary_startup),
>  		CPU1_BOOT_REG);
>  
>  	/* Call Exynos specific smc call */
> 


-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH resend] Documentation: arm: Replace use of virt_to_phys with __pa_symbol Geert Uytterhoeven <geert+renesas@glider.be> - 2017-07-17 15:40 +0200
  Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys  with __pa_symbol Jonathan Corbet <corbet@lwn.net> - 2017-07-17 21:50 +0200
    Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys  with __pa_symbol Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-07-17 23:30 +0200
      Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys  with __pa_symbol Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-18 09:20 +0200
  Re: [PATCH resend] Documentation: arm: Replace use of virt_to_phys  with __pa_symbol Florian Fainelli <f.fainelli@gmail.com> - 2017-07-18 18:50 +0200

csiph-web