Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688646

Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value

Show all headers | View raw

On 07/10/2017 11:25 AM, Moritz Fischer wrote:
> On Thu, Jul 6, 2017 at 11:22 PM, Gustavo A. R. Silva
> <garsilva@embeddedor.com> wrote:
>> Check return value from call to of_match_device()
>> in order to prevent a NULL pointer dereference.
>>
>> In case of NULL print error message and return -ENODEV
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> Reviewed-by: Moritz Fischer <mdf@kernel.org>

Thank you, Moritz.

>> ---
>>  drivers/fpga/altera-hps2fpga.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c
>> index 3066b80..ca8212c 100644
>> --- a/drivers/fpga/altera-hps2fpga.c
>> +++ b/drivers/fpga/altera-hps2fpga.c
>> @@ -143,6 +143,11 @@ static int alt_fpga_bridge_probe(struct platform_device *pdev)
>>         int ret;
>>
>>         of_id = of_match_device(altera_fpga_of_match, dev);
>> +       if (!of_id) {
>> +               dev_err(dev, "failed to match device\n");
>> +               return -ENODEV;
>> +       }
>> +
>>         priv = (struct altera_hps2fpga_data *)of_id->data;
>>
>>         priv->bridge_reset = of_reset_control_get_by_index(dev->of_node, 0);
>> --
>> 2.5.0
>>

-- 
Gustavo A. R. Silva

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device()  return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-07 08:30 +0200
  Re: [PATCH] fpga: altera-hps2fpga: add NULL check on  of_match_device() return value Alan Tull <atull@kernel.org> - 2017-07-10 17:20 +0200
    Re: [PATCH] fpga: altera-hps2fpga: add NULL check on  of_match_device() return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-10 17:30 +0200
  Re: [PATCH] fpga: altera-hps2fpga: add NULL check on  of_match_device() return value Moritz Fischer <moritz.fischer@ettus.com> - 2017-07-10 18:30 +0200
    Re: [PATCH] fpga: altera-hps2fpga: add NULL check on  of_match_device() return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 07:00 +0200

csiph-web