Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1687454

Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335

From Mike Galbraith <efault@gmx.de>
Newsgroups linux.kernel
Subject Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335
Date 2017-07-14 15:50 +0200
Message-ID <u398L-48E-25@gated-at.bofh.it> (permalink)
References (3 earlier) <u2853-5KF-3@gated-at.bofh.it> <u2mB3-6AZ-1@gated-at.bofh.it> <u2o0a-7C7-13@gated-at.bofh.it> <u2o9P-7G6-21@gated-at.bofh.it> <u38Z4-44P-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2017-07-14 at 15:36 +0200, Mike Galbraith wrote:
>  All DRM did was to slip a
> WARN_ON_ONCE() that nouveau triggers into a kernel module where such
> things no longer warn, they blow the box out of the water.

BTW, turn that irksome WARN_ON_ONCE() in drivers/gpu/drm/drm_vblank.c
into a WARN_ONCE(), and all is peachy, you get the warning, box lives.

---
 drivers/gpu/drm/drm_vblank.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -605,7 +605,8 @@ bool drm_calc_vbltimestamp_from_scanoutp
 	 */
 	if (mode->crtc_clock == 0) {
 		DRM_DEBUG("crtc %u: Noop due to uninitialized mode.\n", pipe);
-		WARN_ON_ONCE(drm_drv_uses_atomic_modeset(dev));
+		WARN_ONCE(drm_drv_uses_atomic_modeset(dev), "%s: report me.\n",
+			  dev->driver->name);
 
 		return false;
 	}

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-11 20:00 +0200
  Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-11 20:10 +0200
    Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-11 20:30 +0200
      Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-11 21:00 +0200
        Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-12 09:50 +0200
      Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-12 12:00 +0200
        Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-12 13:30 +0200
          Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-12 13:40 +0200
            Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-12 19:30 +0200
              Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> - 2017-07-12 21:50 +0200
            Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 15:40 +0200
              Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 15:50 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> - 2017-07-14 17:10 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-14 17:20 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Karol Herbst <karolherbst@gmail.com> - 2017-07-14 17:20 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 17:20 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> - 2017-07-14 17:20 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Ilia Mirkin <imirkin@alum.mit.edu> - 2017-07-14 17:30 +0200
                Re: [Nouveau] [regression drm/noveau] suspend to ram -> BOOM:  exception RIP: drm_calc_vbltimestamp_from_scanoutpos+335 Peter Zijlstra <peterz@infradead.org> - 2017-07-14 18:00 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 17:20 +0200
              Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Peter Zijlstra <peterz@infradead.org> - 2017-07-14 18:00 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 18:00 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Peter Zijlstra <peterz@infradead.org> - 2017-07-14 18:20 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-14 18:40 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Josh Poimboeuf <jpoimboe@redhat.com> - 2017-07-14 21:50 +0200
                Re: [regression drm/noveau] suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Mike Galbraith <efault@gmx.de> - 2017-07-15 04:50 +0200
                Re: suspend to ram -> BOOM: exception RIP:  drm_calc_vbltimestamp_from_scanoutpos+335 Jessica Yu <jeyu@kernel.org> - 2017-07-17 19:30 +0200

csiph-web