Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations
Date	2017-07-14 12:00 +0200
Message-ID	<u35ya-1D9-13@gated-at.bofh.it> (permalink)
References	(8 earlier) <tU6jO-3YD-61@gated-at.bofh.it> <tUmRA-6dE-9@gated-at.bofh.it> <tUrRg-Tl-13@gated-at.bofh.it> <tUIfn-34h-13@gated-at.bofh.it> <u2pIC-g1-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

  Hi,

> > > Right we need to know this at device initialization time for both
> > > cases
> > > to initialize VGACommonState structure for that device
> > 
> > Why do you need a VGACommonState?
> > 
> 
> We need to create a GRAPHIC_CONSOLE for vGPU device and specify
> GraphicHwOps so that from its .gfx_update callback, surface can be
> queried and updated.

Yes, you need GraphicHwOps, but there is no need to have a
VGACommonState for that.

> > > and also need
> > > NONE to decide whether to init console vnc or not. We have a
> > > mechanism
> > > to disable console vnc path and we recommend to disable it for
> > > better
> > > performance.
> > 
> > Hmm, maybe we should have a ioctl to configure the refresh rate, or
> > a
> > ioctl to allow qemu ask for a refresh when needed?
> > 
> 
> What is default refresh rate of QEMU if vnc is connected?

/* in ms */
#define GUI_REFRESH_INTERVAL_DEFAULT    30
#define GUI_REFRESH_INTERVAL_IDLE     3000

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Kirti Wankhede <kwankhede@nvidia.com> - 2017-07-12 15:20 +0200
  Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations Gerd Hoffmann <kraxel@redhat.com> - 2017-07-14 12:00 +0200

csiph-web