Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak

From	Eduardo Valentin <eduval@amazon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak
Date	2017-07-11 23:50 +0200
Message-ID	<u2bcB-7F4-17@gated-at.bofh.it> (permalink)
References	<tZd1g-4pZ-9@gated-at.bofh.it> <tZrGV-5VQ-5@gated-at.bofh.it> <tZV2i-8vO-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 05, 2017 at 09:05:14AM -0700, Eduardo Valentin wrote:
> On Tue, Jul 04, 2017 at 01:48:42AM -0700, David Miller wrote:
> > From: Eduardo Valentin <eduval@amazon.com>
> > Date: Mon, 3 Jul 2017 10:06:34 -0700
> > 
> > > We currently get the following kmemleak report:
> >  ...
> > > This patch flags the complete_info ptr object as not a leak as it will
> > > get freed when .complete_priv() is called,
> > 
> > We don't call .complete_priv().  We call .complete().
> 
> True, I can fix this wording in the commit next version.
> 
> > 
> >  for the br mdb case, it
> > > will be freed at br_mdb_complete().
> > > 
> > > Cc: stable <stable@vger.kernel.org> # v4.9+
> > > Reviewed-by: Vallish Vaidyeshwara <vallish@amazon.com>
> > > Signed-off-by: Eduardo Valentin <eduval@amazon.com>
> > 
> > I don't understand why kmemleak cannot see this.
> > 
> > We store the pointer globally when we do the switchdev_port_obv_add()
> > call and it should be able to see that.
> 
> I see and agree. But even then I get these reports consistently on RTM_NEWMDB type.
> This is why I am proposing marking as a non-kmemleak.
> 
> To me, this is only a leak if .complete() never gets called.

Ok. So, in fact, I believe the problem I am seeing in more when switchdev_port_obj_add() fails.

I will send a patch for that.

> 
> 
> -- 
> All the best,
> Eduardo Valentin

-- 
All the best,
Eduardo Valentin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] bridge: mdb: report complete_info ptr as not a kmemleak Eduardo Valentin <eduval@amazon.com> - 2017-07-03 19:10 +0200
  Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a  kmemleak David Miller <davem@davemloft.net> - 2017-07-04 10:50 +0200
    Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a  kmemleak Eduardo Valentin <eduval@amazon.com> - 2017-07-05 18:10 +0200
      Re: [PATCH 1/1] bridge: mdb: report complete_info ptr as not a  kmemleak Eduardo Valentin <eduval@amazon.com> - 2017-07-11 23:50 +0200

csiph-web