Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1686515

Re: [PATCH] nvmet: preserve controller serial number between reboots

Show all headers | View raw

On Thu, Jul 13, 2017 at 03:30:39PM +0300, Sagi Grimberg wrote:
> It seems weird that a subsystem has a serial.

The subsystem is more of a hack I admit. But we don't maintain
configurations for controllers in configfs, do we?

> I'm not sure that a dynamic controller should maintain
> a serial. Dynamic controllers by definition are allocated
> on demand with no state of prior associations. But not sure
> if a serial is a state (it probably isn't). The area is a little
> fuzzy for me.

I'm not certain as well, the only thing I know for sure currently is,
it changes but we use in the standard 60-persistent-storage.rules [1]
as a part of /dev/disk/by-id/nvme-$model-$serial-part%n [2] and I have a bit
of a headace when users use it to identify their partitions in say /etc/fstab
and the link changes as the target generated serial changes.

Maybe we should consider this more as an RFD than a patch.

I'm happy to withdraw if we find a better solution.

[1] https://github.com/systemd/systemd/blob/master/rules/60-persistent-storage.rules
[2] https://github.com/systemd/systemd/blob/master/rules/60-persistent-storage.rules#L27

Thanks,
	Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] nvmet: preserve controller serial number between reboots Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-13 13:10 +0200
  Re: [PATCH] nvmet: preserve controller serial number between reboots Sagi Grimberg <sagi@grimberg.me> - 2017-07-13 14:40 +0200
    Re: [PATCH] nvmet: preserve controller serial number between reboots Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-13 15:00 +0200
    Re: [PATCH] nvmet: preserve controller serial number between         reboots Christoph Hellwig <hch@lst.de> - 2017-07-13 15:10 +0200
      Re: [PATCH] nvmet: preserve controller serial number between reboots Johannes Thumshirn <jthumshirn@suse.de> - 2017-07-13 15:20 +0200
      Re: [PATCH] nvmet: preserve controller serial number between reboots Sagi Grimberg <sagi@grimberg.me> - 2017-07-13 18:40 +0200
        Re: [PATCH] nvmet: preserve controller serial number between         reboots Christoph Hellwig <hch@lst.de> - 2017-07-13 19:20 +0200
  Re: [PATCH] nvmet: preserve controller serial number between reboots Martin Wilck <mwilck@suse.de> - 2017-07-13 17:10 +0200
    Re: [PATCH] nvmet: preserve controller serial number between         reboots Christoph Hellwig <hch@lst.de> - 2017-07-13 17:20 +0200

csiph-web