Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685262

Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

From Andrey Utkin <andrey_utkin@fastmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static
Date 2017-07-11 20:00 +0200
Message-ID <u27C2-5m0-27@gated-at.bofh.it> (permalink)
References <u1M4y-fL-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 10, 2017 at 07:51:03PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static.  Makes the object code smaller and saves nearly 840 bytes
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    9218	    360	      0	   9578	   256a	solo6x10-tw28.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    8237	    504	      0	   8741	   2225	solo6x10-tw28.o
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Andrey Utkin <andrey_utkin@fastmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Colin King <colin.king@canonical.com> - 2017-07-10 21:00 +0200
  Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc  static Andrey Utkin <andrey_utkin@fastmail.com> - 2017-07-11 20:00 +0200
  Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc  static Ismael Luceno <ismael@iodev.co.uk> - 2017-07-11 21:10 +0200

csiph-web