Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685051

Re: [PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for NO_DMA=y

Show all headers | View raw

On Mon, Jul 10, 2017 at 04:31:54PM +0100, Robin Murphy wrote:
> On 10/07/17 15:56, Christoph Hellwig wrote:
> > This looks reasonable to me, I'd be happy to pick it up.  Can you send
> > it as a series with the reverts?
> 
> The fact remains that the FSL driver is still doing the wrong thing
> though - set_dma_ops(dev1, get_dma_ops(dev2)) is just a hack which
> happens to work on platforms which don't keep other arch-internal DMA
> info as well. I did start writing a patch somewhere to fix this thing to
> actually do proper DMA configuration (originally in the context of not
> abusing arch_setup_dma_ops()), but Arnd's fix is probably simpler.
> 
> I don't think it makes an awful lot of sense for code without a DMA API
> dependency to be calling set_dma_ops() - AFAIU the only reason it's
> available to drivers at all is for particular RDMA cases which know that
> their "DMA" is actually done by CPU threads, and want to optimise for that.

Even that code should require the DMA API.  So yes, maybe we should
fix the code to propagate the settings by another means.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for NO_DMA=y Geert Uytterhoeven <geert@linux-m68k.org> - 2017-07-09 21:40 +0200
  Re: [PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for NO_DMA=y Arnd Bergmann <arnd@arndb.de> - 2017-07-10 10:00 +0200
  Re: [PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for         NO_DMA=y Christoph Hellwig <hch@lst.de> - 2017-07-10 17:00 +0200
    Re: [PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for NO_DMA=y Robin Murphy <robin.murphy@arm.com> - 2017-07-10 17:40 +0200
      Re: [PATCH/RFC] dma-mapping: Provide dummy set_dma_ops() for         NO_DMA=y Christoph Hellwig <hch@lst.de> - 2017-07-11 16:10 +0200

csiph-web