Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding
Date	2017-07-10 05:50 +0200
Message-ID	<u1xRT-8am-1@gated-at.bofh.it> (permalink)
References	<u0c37-2WU-3@gated-at.bofh.it> <u0c38-2WU-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote:
> Document "mac-offset" binding that will be used by at24 EEPROM driver.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index a50dc01..3dd267c 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -35,10 +35,13 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - mac-offset: offset in EEPROM where MAC address starts
> +

This doesn't scale if you have multiple things you need the offset to, 
and we already have a binding for this. Use the nvmem binding.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Add at24 functionality to read MAC form different EEPROM offsets Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-07-06 12:20 +0200
  [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-07-06 12:20 +0200
    Re: [PATCH 1/3] dt-bindings: i2c: eeprom: document all at24 bindings Rob Herring <robh@kernel.org> - 2017-07-10 05:50 +0200
  [PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-07-06 12:20 +0200
  [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-07-06 12:20 +0200
    Re: [PATCH 3/3] dt-bindings: i2c: eeprom: document "mac-offset"  binding Rob Herring <robh@kernel.org> - 2017-07-10 05:50 +0200

csiph-web