Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1683768

Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and devm_kmemdup() return values

Show all headers | View raw

On Fri, 7 Jul 2017 11:26:35 +0200
Peter Rosin <peda@axentia.se> wrote:

> On 2017-07-07 06:57, Peter Rosin wrote:
> > On 2017-07-07 06:53, Gustavo A. R. Silva wrote:  
> >> Check return values from call to devm_kzalloc() and devm_kmemup()  
> > 
> > If someone cares enough: s/devm_kmemup/evm_kmemdup/  
> 
> Strange, there seems to be some inherent shortage of 'd' characters...
> 
> Cheers,
> pea :-)
> 
> >   
> >> in order to prevent a NULL pointer dereference.
> >>
> >> This issue was detected using Coccinelle and the following semantic patch:
> >>
> >> @@
> >> expression x;
> >> identifier fld;
> >> @@
> >>
> >> * x = devm_kzalloc(...);
> >>    ... when != x == NULL
> >>    x->fld
> >>
> >> Cc: Peter Rosin <peda@axentia.se>
> >> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>  
> > 
> > Either way,
> > 
> > Reviewed-by: Peter Rosin <peda@axentia.se>
> > 
> > Thanks!
> > 
The relevant patch adding the file in questions hasn't yet worked it's
way back to the iio tree so I can't apply this until it does.

That is likely to be a few weeks away yet.  Please give me a poke if
I seem to have forgotten it!

Jonathan  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and  devm_kmemdup() return values "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-07 07:00 +0200
  Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and  devm_kmemdup() return values Jonathan Cameron <jic23@kernel.org> - 2017-07-09 19:20 +0200
    Re: [PATCH] iio: multiplexer: add NULL check on devm_kzalloc() and  devm_kmemdup() return values "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-10 21:50 +0200

csiph-web