Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1682683

Re: [git pull] vfs.git pile 11

Show all headers | View raw

On Thu, Jul 06, 2017 at 12:45:36PM -0700, Kees Cook wrote:
> 
> +   if (unlikely(!check_copy_size(addr, bytes, false)))
> +       return false;
> +   else
> +       return _copy_from_iter_full(addr, bytes, i);
> 
> Can these be rewritten to avoid the double-negative?

Matter of taste - I've no strong preferences here.

> +   might_fault();
> 
> Should this be might_sleep()? Just from reading the patch it looked
> like you were adding might_sleep()s in the other cases.

D'oh - shouldn't have written that pull request message before the
first cup of coffee...  might_sleep() it is, of course.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[git pull] vfs.git pile 11 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-06 11:20 +0200
  Re: [git pull] vfs.git pile 11 Kees Cook <keescook@chromium.org> - 2017-07-06 21:50 +0200
    Re: [git pull] vfs.git pile 11 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-06 22:20 +0200
      Re: [git pull] vfs.git pile 11 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-06 22:30 +0200
        Re: [git pull] vfs.git pile 11 Al Viro <viro@ZenIV.linux.org.uk> - 2017-07-06 23:30 +0200
          Re: [git pull] vfs.git pile 11 Linus Torvalds <torvalds@linux-foundation.org> - 2017-07-07 07:10 +0200

csiph-web