Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1682423

Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists

From Chao Yu <chao@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists
Date 2017-07-06 15:20 +0200
Message-ID <u0eRj-4MZ-15@gated-at.bofh.it> (permalink)
References <u0cPv-3uf-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Yunlong,

It looks there is no way to create discard thread redundantly,
so here we don't need to check this?

Thanks,

On 2017/7/6 19:05, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/segment.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 4c246e3..b48d004 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi)
>  
>  	if (SM_I(sbi)->dcc_info) {
>  		dcc = SM_I(sbi)->dcc_info;
> +		if (dcc->f2fs_issue_discard)
> +			return err;
>  		goto init_thread;
>  	}
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] f2fs: no need to create issue_discard_thread if it exists Yunlong Song <yunlong.song@huawei.com> - 2017-07-06 13:10 +0200
  Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists Chao Yu <chao@kernel.org> - 2017-07-06 15:20 +0200
    Re: [PATCH] f2fs: no need to create issue_discard_thread if it exists Yunlong Song <yunlong.song@huawei.com> - 2017-07-07 04:10 +0200

csiph-web