Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628965

[PATCH v3 13/15] staging: ccree: fix array_size.cocci warnings

Show all headers | View raw

From: kbuild test robot <lkp@intel.com>

drivers/staging/ccree/ssi_sysfs.c:319:34-35: WARNING: Use ARRAY_SIZE
drivers/staging/ccree/ssi_sysfs.c:429:34-35: WARNING: Use ARRAY_SIZE

 Use ARRAY_SIZE instead of dividing sizeof array with sizeof an element

Semantic patch information:
 This makes an effort to find cases where ARRAY_SIZE can be used such as
 where there is a division of sizeof the array by the sizeof its first
 element or by any indexed element or the element type. It replaces the
 division of the two sizeofs by ARRAY_SIZE.

Generated by: scripts/coccinelle/misc/array_size.cocci

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 drivers/staging/ccree/ssi_sysfs.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ccree/ssi_sysfs.c b/drivers/staging/ccree/ssi_sysfs.c
index 6db7573..7c514c1 100644
--- a/drivers/staging/ccree/ssi_sysfs.c
+++ b/drivers/staging/ccree/ssi_sysfs.c
@@ -316,7 +316,7 @@ static ssize_t ssi_sys_help_show(struct kobject *kobj,
 	int i=0, offset = 0;
 
 	offset += scnprintf(buf + offset, PAGE_SIZE - offset, "Usage:\n");
-	for ( i = 0; i < (sizeof(help_str)/sizeof(help_str[0])); i+=2) {
+	for ( i = 0; i < ARRAY_SIZE(help_str); i+=2) {
 	   offset += scnprintf(buf + offset, PAGE_SIZE - offset, "%s\t\t%s\n", help_str[i], help_str[i+1]);
 	}
 	return offset;
@@ -426,8 +426,7 @@ int ssi_sysfs_init(struct kobject *sys_dev_obj, struct ssi_drvdata *drvdata)
 	/* Initialize top directory */
 	retval = sys_init_dir(&sys_top_dir, drvdata, sys_dev_obj,
 				"cc_info", ssi_sys_top_level_attrs,
-				sizeof(ssi_sys_top_level_attrs) /
-				sizeof(struct kobj_attribute));
+				ARRAY_SIZE(ssi_sys_top_level_attrs));
 	return retval;
 }
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/15] staging: ccree: add Arm TrustZone CryptoCell REE driver Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:30 +0200
  [PATCH v3 04/15] staging: ccree: add IV generation support Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:30 +0200
  [PATCH v3 14/15] staging: ccree: fix ifnullfree.cocci warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 10/15] staging: ccree: remove useless NULL test of field Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 11/15] staging: ccree: fix platform_no_drv_owner.cocci warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 07/15] staging: ccree: add TODO list Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 15/15] staging: ccree: fix ifnullfree.cocci warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 12/15] staging: ccree: fix semicolon.cocci warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 08/15] staging: ccree: add DT bindings for Arm CryptoCell Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 09/15] MAINTAINERS: add Gilad BY as ccree maintainer Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200
  [PATCH v3 13/15] staging: ccree: fix array_size.cocci warnings Gilad Ben-Yossef <gilad@benyossef.com> - 2017-04-23 11:40 +0200

csiph-web