Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1627688

Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()
Date 2017-04-20 19:20 +0200
Message-ID <tynUm-3h3-17@gated-at.bofh.it> (permalink)
References <tykjM-11j-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/20/2017 06:29 AM, Alexander Kochetkov wrote:
> Currently driver use phy_start_aneg() in arc_emac_open() to bring
> up PHY. But phy_start() function is more appropriate for this purposes.
> Besides that it call phy_start_aneg() as part of PHY startup sequence
> it also can correctly bring up PHY from error and suspended states.
> So the patch replace phy_start_aneg() to phy_start().
> 
> Also the patch add call to phy_stop() to arc_emac_stop() to allow
> the PHY device to be fully suspended when the interface is unused.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Alexander Kochetkov <al.kochet@gmail.com> - 2017-04-20 15:30 +0200
  Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() Florian Fainelli <f.fainelli@gmail.com> - 2017-04-20 19:20 +0200
  Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop() David Miller <davem@davemloft.net> - 2017-04-21 21:30 +0200

csiph-web