RE: [PATCH v3 4/7] powerpc: kprobes: use safer string functions in kprobe_lookup_name()

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH v3 4/7] powerpc: kprobes: use safer string functions in kprobe_lookup_name()
Date	2017-04-21 19:10 +0200
Message-ID	<tyKee-8vc-27@gated-at.bofh.it> (permalink)
References	<txXnb-3yQ-3@gated-at.bofh.it> <txXnc-3yQ-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Naveen N. Rao
> Sent: 19 April 2017 13:51
...
>  			dot_name[0] = '\0';
> -			strncat(dot_name, name, sizeof(dot_name) - 1);
> +			strlcat(dot_name, name, sizeof(dot_name));
...

Is that really zeroing the first byte just so it can append to it?

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/7] powerpc: kprobes: use safer string functions in kprobe_lookup_name() "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2017-04-19 15:00 +0200
  RE: [PATCH v3 4/7] powerpc: kprobes: use safer string functions in  kprobe_lookup_name() David Laight <David.Laight@ACULAB.COM> - 2017-04-21 19:10 +0200

csiph-web