Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626796

Re: [PATCH] hp-wmi: Do not shadow error values

Show all headers | View raw

On Wed, Apr 19, 2017 at 10:36:39PM +0200, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
> 
> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
> ...) using hp_wmi_perform_query to perform an HP WMI query shadow the
> returned value in case of error.
> 
> We return -EINVAL only when the HP WMI query returns a positive value
> (the specific error code) to not mix this up with the actual value
> returned by the helper function.
> 
> Signed-off-by: Carlo Caione <carlo@endlessm.com>

Queued to testing, thanks Carlo.


-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] hp-wmi: Do not shadow error values Carlo Caione <carlo@caione.org> - 2017-04-19 22:40 +0200
  Re: [PATCH] hp-wmi: Do not shadow error values Darren Hart <dvhart@infradead.org> - 2017-04-19 23:00 +0200

csiph-web