Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode
Date	2017-04-19 18:30 +0200
Message-ID	<ty0Es-5Fr-63@gated-at.bofh.it> (permalink)
References	<tulxM-3uX-9@gated-at.bofh.it> <tulxM-3uX-15@gated-at.bofh.it> <tvRFf-6Or-13@gated-at.bofh.it> <tvTe2-7YO-13@gated-at.bofh.it> <tvW2e-1tc-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 14, 2017 at 2:07 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Thu, Apr 13, 2017 at 10:09:43PM +0200, Carlo Caione wrote:
>> On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart <dvhart@infradead.org> wrote:
>> > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote:

> EINVAL is being used to broadly here. If the input values are incorrect, then
> yes -EINVAL is the right response. However, if the query was unsuccessful, that
> is more appropriately -EIO.
>
> If the handle/method doesn't exist, that would be -ENXIO.
>
> However, your changes make the driver self-consistent and I'll apply them as is
> to testing.

Darren, if it's not yet in for-next, I would like Carlo to update his
patch 1. I think it's better if we not shadow negative error code from
the callee.

-- 
With Best Regards,
Andy Shevchenko

Thread

Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Darren Hart <dvhart@infradead.org> - 2017-04-13 20:30 +0200
  Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Carlo Caione <carlo@endlessm.com> - 2017-04-13 22:10 +0200
    Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Darren Hart <dvhart@infradead.org> - 2017-04-14 01:10 +0200
      Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-04-19 18:30 +0200
        Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Darren Hart <dvhart@infradead.org> - 2017-04-19 22:20 +0200

csiph-web