Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625137

Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation

Show all headers | View raw

On Thu, 2017-04-13 at 18:10 +0200, Peter Rosin wrote:
> On 2017-04-13 16:24, Philipp Zabel wrote:
> > According to the device tree binding documentation, the compatible
> > should be "gpio-mux", not "mux-gpio".
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  drivers/mux/mux-gpio.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
> > index b304845c4812b..227d3572e6dbf 100644
> > --- a/drivers/mux/mux-gpio.c
> > +++ b/drivers/mux/mux-gpio.c
> > @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
> >  };
> >  
> >  static const struct of_device_id mux_gpio_dt_ids[] = {
> > -	{ .compatible = "mux-gpio", },
> > +	{ .compatible = "gpio-mux", },
> >  	{ /* sentinel */ }
> >  };
> >  MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
> > 
> 
> Oh, crap, right you are. However, the mux patch series is not frozen yet,
> and I think Greg KH will want this fixed before they are. So, I guess I'll
> send a v11 of the mux series (shortly) instead of having this extra patch.

Of course, I wasn't aware.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mux: mux-gpio: fix compatible according to binding documentation Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-13 16:30 +0200
  Re: [PATCH] mux: mux-gpio: fix compatible according to binding  documentation Philipp Zabel <p.zabel@pengutronix.de> - 2017-04-18 10:30 +0200

csiph-web