Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.
Date	2017-04-17 23:50 +0200
Message-ID	<txmGZ-5VR-5@gated-at.bofh.it> (permalink)
References	<txhHk-2S7-15@gated-at.bofh.it> <txj6p-3CW-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Sean Paul <seanpaul@chromium.org> writes:

> On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote:
>> We were returning without decrementing if the error happened, meaning
>> that at the next submit we wouldn't try to bring up the power domain.
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>
> This change looks good to me. It seems a little odd to wrap pm_runtime which
> is already refcounted in another refcount, but I'm really not familiar with
> the driver, and I'm sure there's a good reason for it.
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>

Yeah, it's an unfortunate hack because the reset control is buried in
the power domain driver on the RPi, so we have to get the power domain
actually off (0 refcount) in order to reset the GPU.

Yay for building around closed-source firmware :(

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out. Eric Anholt <eric@anholt.net> - 2017-04-17 18:30 +0200
  Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors  out. Sean Paul <seanpaul@chromium.org> - 2017-04-17 20:00 +0200
    Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out. Eric Anholt <eric@anholt.net> - 2017-04-17 23:50 +0200

csiph-web