Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625337

[PATCH] platform: x86: intel-hid: Add missing ->thaw callback

Show all headers | View raw

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The intel-hid driver is missing a PM ->thaw callback allowing the
device to go back to the operational state after creating a
hibernation image or when there is an image restoration error during
resume.

The lack of the ->thaw callback basically means that all events
signaled by the device are discarded after a hibernation image has
been created which may be problematic, for example, if the image
cannot be saved (eg. due to an I/O issue with storage).

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/platform/x86/intel-hid.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-pm/drivers/platform/x86/intel-hid.c
===================================================================
--- linux-pm.orig/drivers/platform/x86/intel-hid.c
+++ linux-pm/drivers/platform/x86/intel-hid.c
@@ -136,6 +136,7 @@ static int intel_hid_pl_resume_handler(s
 
 static const struct dev_pm_ops intel_hid_pl_pm_ops = {
 	.freeze  = intel_hid_pl_suspend_handler,
+	.thaw  = intel_hid_pl_resume_handler,
 	.restore  = intel_hid_pl_resume_handler,
 	.suspend  = intel_hid_pl_suspend_handler,
 	.resume  = intel_hid_pl_resume_handler,

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform: x86: intel-hid: Add missing ->thaw callback "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-04-18 16:00 +0200
  Re: [PATCH] platform: x86: intel-hid: Add missing ->thaw callback Darren Hart <dvhart@infradead.org> - 2017-04-18 18:10 +0200
    Re: [PATCH] platform: x86: intel-hid: Add missing ->thaw callback Alex Hung <alex.hung@canonical.com> - 2017-04-18 19:40 +0200

csiph-web