Re: [PATCH 2/4] add tiocsti_restrict variable

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] add tiocsti_restrict variable
Date	2017-04-17 09:00 +0200
Message-ID	<tx8NI-5UK-7@gated-at.bofh.it> (permalink)
References	<tx81j-5DY-7@gated-at.bofh.it> <tx81k-5DY-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 17, 2017 at 02:07:04AM -0400, Matt Brown wrote:
> adding extern variable tiocsti_restrict to allow it to be included
> in sysctl
> 
> Signed-off-by: Matt Brown <matt@nmatt.com>
> ---
>  include/linux/tty.h | 2 ++
>  1 file changed, 2 insertions(+)

I'm all for breaking up changes to be tiny logical pieces, but this is
really not needed.  Please make it "one logical feature" per patch.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] add tiocsti_restrict variable Matt Brown <matt@nmatt.com> - 2017-04-17 08:10 +0200
  Re: [PATCH 2/4] add tiocsti_restrict variable Greg KH <gregkh@linuxfoundation.org> - 2017-04-17 09:00 +0200

csiph-web