Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623585

[tip:irq/urgent] irqchip/irq-imx-gpcv2: Fix spinlock initialization

Show all headers | View raw

Commit-ID:  75eb5e1e7b4edbc8e8f930de59004d21cb46961f
Gitweb:     http://git.kernel.org/tip/75eb5e1e7b4edbc8e8f930de59004d21cb46961f
Author:     Tyler Baker <tyler.baker@linaro.org>
AuthorDate: Thu, 13 Apr 2017 15:27:31 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Fri, 14 Apr 2017 10:55:05 +0200

irqchip/irq-imx-gpcv2: Fix spinlock initialization

The raw_spinlock in the IMX GPCV2 interupt chip is not initialized before
usage. That results in a lockdep splat:

  INFO: trying to register non-static key.
  the code is fine but needs lockdep annotation.
  turning off the locking correctness validator.

Add the missing raw_spin_lock_init() to the setup code.

Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup sources")
Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Cc: jason@lakedaemon.net
Cc: marc.zyngier@arm.com
Cc: shawnguo@kernel.org
Cc: andrew.smirnov@gmail.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20170413222731.5917-1-tyler.baker@linaro.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

---
 drivers/irqchip/irq-imx-gpcv2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 15af9a9..2d203b4 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -230,6 +230,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
 		return -ENOMEM;
 	}
 
+	raw_spin_lock_init(&cd->rlock);
+
 	cd->gpc_base = of_iomap(node, 0);
 	if (!cd->gpc_base) {
 		pr_err("fsl-gpcv2: unable to map gpc registers\n");

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip/irq-imx-gpcv2: fix spinlock initialization Tyler Baker <tyler.baker@linaro.org> - 2017-04-14 00:30 +0200
  [tip:irq/urgent] irqchip/irq-imx-gpcv2: Fix spinlock initialization tip-bot for Tyler Baker <tipbot@zytor.com> - 2017-04-14 11:10 +0200
  Re: [PATCH] irqchip/irq-imx-gpcv2: fix spinlock initialization Marc Zyngier <marc.zyngier@arm.com> - 2017-04-15 15:50 +0200
    Re: [PATCH] irqchip/irq-imx-gpcv2: fix spinlock initialization Thomas Gleixner <tglx@linutronix.de> - 2017-04-15 16:00 +0200
      Re: [PATCH] irqchip/irq-imx-gpcv2: fix spinlock initialization Marc Zyngier <marc.zyngier@arm.com> - 2017-04-15 16:20 +0200

csiph-web