Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1621620

Re: [git pull] vfs fixes

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Apr 11, 2017, at 12:48 AM, Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Mon, Apr 10, 2017 at 11:10:19PM -0700, Linus Torvalds wrote:
> 
>> It looks odd because the lock part is
>> 
>>                if (flags & LOOKUP_RCU)
>>                        rcu_read_lock();
>> 
>> ie it's locked conditionally, and the code in between does not seem to
>> return every time LOOKUP_RCU is clear.
>> 
>> So mind giving this a look? Is it as obviously buggy as I think it is,
>> or is there something I'm missing?
> 
> It's more obscure than I would like, and can grow into a bug one day, but...
> nd_jump_root() can only return non-zero if you have LOOKUP_RCU.  So without
> LOOKUP_RCU in flags, this
>                if (flags & LOOKUP_RCU)
>                        rcu_read_lock();
>                set_root(nd);
>                if (likely(!nd_jump_root(nd)))
>                        return s;
>                nd->root.mnt = NULL;
>                rcu_read_unlock();
> won't get to that rcu_read_unlock() at all - it'll get zero from nd_jump_root()
> and proceed to return s;

So possibly a comment like the following would be helpful:

		rcu_read_unlock(); /* nd_jump_root() returns if !LOOKUP_RCU */

so that us mere mortals have a chance to understand this in the future?

Cheers, Andreas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [git pull] vfs fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-04-11 08:20 +0200
  Re: [git pull] vfs fixes Al Viro <viro@ZenIV.linux.org.uk> - 2017-04-11 08:50 +0200
    Re: [git pull] vfs fixes Andreas Dilger <adilger@dilger.ca> - 2017-04-11 23:10 +0200
      Re: [git pull] vfs fixes Linus Torvalds <torvalds@linux-foundation.org> - 2017-04-12 09:10 +0200

csiph-web