Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1623292

Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy

Show all headers | View raw

On Thu, Apr 13, 2017 at 10:28:09PM +0300, Sergei Shtylyov wrote:
> On 04/13/2017 10:11 PM, Grygorii Strashko wrote:
> 
> >Now the command:
> >	ethtool --phy-statistics eth0
> >will cause system crash with meassage "Unable to handle kernel NULL pointer
> >dereference at virtual address 00000010" from:
> >
> > (kszphy_get_stats) from [<c069f1d8>] (ethtool_get_phy_stats+0xd8/0x210)
> > (ethtool_get_phy_stats) from [<c06a0738>] (dev_ethtool+0x5b8/0x228c)
> > (dev_ethtool) from [<c06b5484>] (dev_ioctl+0x3fc/0x964)
> > (dev_ioctl) from [<c0679f7c>] (sock_ioctl+0x170/0x2c0)
> > (sock_ioctl) from [<c02419d4>] (do_vfs_ioctl+0xa8/0x95c)
> > (do_vfs_ioctl) from [<c02422c4>] (SyS_ioctl+0x3c/0x64)
> > (SyS_ioctl) from [<c0107d60>] (ret_fast_syscall+0x0/0x44)
> >
> >The reason: phy_driver structure for KSZ9031 phy has no .probe() callback
> >defined. As result, struct phy_device *phydev->priv pointer will not be
> >initializes (null).
> >This issue will affect also following phys:
> > KSZ8795, KSZ886X, KSZ8873MLL, KSZ9031, KSZ9021, KSZ8061, KS8737
> >
> >Fix it by:
> >- adding .probe() = kszphy_probe() callback to KSZ9031, KSZ9021
> >phys. The kszphy_probe() can be re-used as it doesn't do any phy specific
> >settings.
> >- removing statistic callbacks from other phys (KSZ8795, KSZ886X,
> >KSZ8873MLL, KSZ8061, KS8737) as they doesn't have corresponding
> >statistic counters.
> 
>    Not sure how the 2nd change fixes the reported issue. It looks
> like a material for a separate patch...

There are two different cases here:

1) The hardware supports the stats. So a probe function is needed, but
is missing.

2) The hardware does not support the stats, so there should not be
stats ops.

The same crash will happen, independent of which one of the above is
true. You need to fix them both, to stop it crashing.

      Andrew

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] net: phy: micrel: fix crash when statistic requested for KSZ9031 phy Grygorii Strashko <grygorii.strashko@ti.com> - 2017-04-13 21:20 +0200
  Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested  for KSZ9031 phy Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-04-13 21:30 +0200
    Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested  for KSZ9031 phy Andrew Lunn <andrew@lunn.ch> - 2017-04-13 21:40 +0200
  Re: [PATCH v3] net: phy: micrel: fix crash when statistic requested  for KSZ9031 phy Florian Fainelli <f.fainelli@gmail.com> - 2017-04-13 21:40 +0200
  Re: [PATCH v3] net: phy: micrel: fix crash when statistic  requested for KSZ9031 phy David Miller <davem@davemloft.net> - 2017-04-17 19:40 +0200

csiph-web