Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1620987

Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation
Date 2017-04-11 09:50 +0200
Message-ID <tuYIN-42a-5@gated-at.bofh.it> (permalink)
References <tuKZd-3CL-61@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Apr 10, 2017 at 7:00 PM, Andreas Klinger <ak@it-klinger.de> wrote:

> While calculating the compensation of the humidity there are negative values
> interpreted as unsigned because of unsigned variables used.  These values as
> well as the constants need to be casted to signed as indicated by the
> documentation of the sensor.
>
> Changes in v2:
> - cast also constants to signed; otherwise calculation is not correct
>
> I removed the Acked-By of Linus Walleij because of another change in the
> calculation. Don't know how it should be treated.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

You guys do an awesome job at maintaining the sensor code, thanks.

Yours,
Linus Walleij

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation Andreas Klinger <ak@it-klinger.de> - 2017-04-10 19:10 +0200
  Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation Linus Walleij <linus.walleij@linaro.org> - 2017-04-11 09:50 +0200
  Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation Matt Ranostay <matt.ranostay@konsulko.com> - 2017-04-12 02:00 +0200
    Re: [PATCH v2] IIO: bmp280-core.c: fix error in humidity calculation Jonathan Cameron <jic23@kernel.org> - 2017-04-14 16:20 +0200

csiph-web