Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1620226

Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity information code

Show all headers | View raw

Hi,

On 10/04/17 16:05, Russell King - ARM Linux wrote:
> On Mon, Mar 27, 2017 at 02:18:16PM +0100, Juri Lelli wrote:
> > arm and arm64 topology.c share a lot of code related to parsing of capacity
> > information. This is v3 of a solution [1] (based on Will's, Catalin's and
> > Mark's off-line suggestions) to move such common code in a single place:
> > drivers/base/arch_topology.c (by creating such file and conditionally compiling
> > it for arm and arm64 only).
> 
> I think overall this is okay, with the exception of one patch which seems
> to be wrongly worded.

As I said in reply to your comments, we could also consider dropping
that patch entirely. What's your opinion?

> Once that's resolved, then:
> 
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
> 
> for the series.
> 

Also, I'd like to update 3/9 as suggested by Vincent.

Thanks for the review.

Best,

- Juri

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity  information code Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-10 17:10 +0200
  Re: [PATCH v3 0/9] Fix issues and factorize arm/arm64 capacity  information code Juri Lelli <juri.lelli@arm.com> - 2017-04-10 18:30 +0200

csiph-web