Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618502

Re: [PATCH v3 33/37] mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset

Show all headers | View raw

Hi Leonard,

2017-04-06 23:08 GMT+09:00 Leonard Crestez <leonard.crestez@nxp.com>:
> On Thu, Mar 30, 2017 at 11:15 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>>
>> Some NAND controllers are using DMA engine requiring a specific
>> buffer alignment.  The core provides no guarantee on the nand_buffers
>> pointers, which forces some drivers to allocate their own buffers
>> and pass the NAND_OWN_BUFFERS flag.
>>
>> Rework the nand_buffers allocation logic to allocate each buffer
>> independently.  This should make most NAND controllers/DMA engine
>> happy, and allow us to get rid of these custom buf allocation in
>> NAND controller drivers.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
>> @@ -4914,8 +4930,12 @@ void nand_cleanup(struct nand_chip *chip)
>> >         /* Free bad block table memory */
>>         kfree(chip->bbt);
>> -       if (!(chip->options & NAND_OWN_BUFFERS))
>> +       if (!(chip->options & NAND_OWN_BUFFERS)) {
>> +               kfree(chip->buffers->databuf);
>> +               kfree(chip->buffers->ecccode);
>> +               kfree(chip->buffers->ecccalc);
>>                 kfree(chip->buffers);
>> +       }
>
> It seems that chip->buffers might not be allocated at this point, for
> example if nand_cleanup is called during a failed probe. You should
> check if (chip->buffers != NULL) before freeing stuff inside it.

You are right.

The failure path in NAND drivers is messy.   :-(
nand_cleanup() may be called before nand_scan_tail()
finishes successfully...

I will send a fixup patch.  Thanks!



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 31/37] mtd: nand: denali: fix raw and oob accessors for syndrome page layout Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-30 10:20 +0200
  [PATCH v3 32/37] mtd: nand: denali: support hardware-assisted erased page detection Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-30 10:30 +0200
    Re: [PATCH v3 32/37] mtd: nand: denali: support hardware-assisted  erased page detection Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-03-30 18:40 +0200
  [PATCH v3 33/37] mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-03-30 10:30 +0200
    Re: [PATCH v3 33/37] mtd: nand: allocate aligned buffers if  NAND_OWN_BUFFERS is unset Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-07 08:50 +0200
      Re: [PATCH v3 33/37] mtd: nand: allocate aligned buffers if  NAND_OWN_BUFFERS is unset Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-04-09 09:40 +0200
    Re: [PATCH v3 33/37] mtd: nand: allocate aligned buffers if  NAND_OWN_BUFFERS is unset Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-04-09 16:20 +0200
      Re: [PATCH v3 33/37] mtd: nand: allocate aligned buffers if  NAND_OWN_BUFFERS is unset Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-10 02:30 +0200

csiph-web