Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1617962
| From | Jeffy Chen <jeffy.chen@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered |
| Date | 2017-04-06 14:40 +0200 |
| Message-ID | <tteRI-5K-33@gated-at.bofh.it> (permalink) |
| References | <tteRH-5K-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. Add a sanity check here to prevent that from happening. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/drm_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 7d6deaa..15beb11 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -674,7 +674,7 @@ long drm_ioctl(struct file *filp, dev = file_priv->minor->dev; - if (drm_device_is_unplugged(dev)) + if (drm_device_is_unplugged(dev) || !dev->registered) return -ENODEV; is_driver_ioctl = nr >= DRM_COMMAND_BASE && nr < DRM_COMMAND_END; -- 2.1.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-04-06 14:40 +0200
[PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-04-06 14:40 +0200
Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Daniel Vetter <daniel@ffwll.ch> - 2017-04-07 09:20 +0200
Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered jeffy <jeffy.chen@rock-chips.com> - 2017-04-07 11:30 +0200
Re: [PATCH v5 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Daniel Vetter <daniel@ffwll.ch> - 2017-04-07 20:40 +0200
[PATCH v5 05/12] drm/rockchip: cdn-dp: Don't try to release firmware when not loaded Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-04-06 14:40 +0200
[PATCH v5 10/12] drm/rockchip: Reoder drm bind/unbind sequence Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-04-06 14:40 +0200
Re: [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error Sean Paul <seanpaul@chromium.org> - 2017-04-07 19:40 +0200
csiph-web