Groups > linux.kernel > #1619274

Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1.

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1.
Date	2017-04-08 14:30 +0200
Message-ID	<ttXF7-59X-7@gated-at.bofh.it> (permalink)
References	(5 earlier) <tjAA9-1nE-1@gated-at.bofh.it> <tkhc5-5PI-9@gated-at.bofh.it> <tkBDQ-3Ed-3@gated-at.bofh.it> <ttcmS-6Rh-11@gated-at.bofh.it> <ttNZ7-7zd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Apr 08, 2017 at 10:02:46AM +0800, Herbert Xu wrote:
> On Thu, Apr 06, 2017 at 05:54:14PM +0800, Herbert Xu wrote:
> > On Mon, Mar 13, 2017 at 07:06:01PM +0200, Krzysztof Kozlowski wrote:
> > >
> > > I bisected this to commit f1c131b45410 ("crypto: xts - Convert to
> > > skcipher"). The s5p-sss driver stays the same... but the xts changes and
> > > as a result we have a NULL pointer dereference (actually of value
> > > 00000004):
> > > [   18.930195] Unable to handle kernel NULL pointer dereference at virtual address 00000004
> > > ...
> > > [   18.972325] [<c0313c98>] (post_crypt) from [<c031408c>] (decrypt_done+0x4c/0x54)
> > > [   18.972343] [<c031408c>] (decrypt_done) from [<c056309c>] (s5p_aes_interrupt+0x1bc/0x208)
> > > [   18.972360] [<c056309c>] (s5p_aes_interrupt) from [<c0164930>] (irq_thread_fn+0x1c/0x54)
> > > 
> > > Any hints?
> > 
> > I haven't found any smoking guns, but the locking between the
> > tasklet and the IRQ routine looks suspect.  First of all the
> > tasklet is modifying the dev structure without holding any locks.
> 
> I think I see the problem.  Could you please try this patch and
> let me know if it fixes the crash?

Yes, fixed! Thanks.
Tested on Odroid XU3 with following script:
https://github.com/krzk/tools/blob/master/tests/s5p-sss-cryptsetup.sh

Tested-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-06 12:00 +0200
  Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-08 04:10 +0200
    Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for  4.10.1. Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-08 14:30 +0200

csiph-web