Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1618830

Re: tty crash in tty_ldisc_receive_buf()

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: tty crash in tty_ldisc_receive_buf()
Date 2017-04-07 16:10 +0200
Message-ID <ttCKn-8a9-43@gated-at.bofh.it> (permalink)
References <tt9Il-5mv-1@gated-at.bofh.it> <ttfE5-B0-7@gated-at.bofh.it> <ttqzv-aP-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Apr 6, 2017 at 8:03 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Thu, 2017-04-06 at 08:28 -0500, Rob Herring wrote:
>>
>> Can you try this one [1].
>>
>> Rob
>>
>> [1] https://lkml.org/lkml/2017/3/23/569
>
> Unless I missed something, that patch doesn't change barriers or
> locking, so I don't see how it could fix anything ...

Only because that's a code path that I changed recently and the
locking and ordering appears to be tricky.

> Mind you we haven't quite figured out exactly what's happening here.

Is this with a serial port? There were some changes to serial_core close in 4.9.

Rob

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

tty crash in tty_ldisc_receive_buf() Michael Neuling <mikey@neuling.org> - 2017-04-06 09:10 +0200
  Re: tty crash in tty_ldisc_receive_buf() Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-04-06 09:20 +0200
  Re: tty crash in tty_ldisc_receive_buf() Rob Herring <robh@kernel.org> - 2017-04-06 15:30 +0200
    Re: tty crash in tty_ldisc_receive_buf() Michael Neuling <mikey@neuling.org> - 2017-04-07 02:50 +0200
    Re: tty crash in tty_ldisc_receive_buf() Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-04-07 03:10 +0200
      Re: tty crash in tty_ldisc_receive_buf() Rob Herring <robh@kernel.org> - 2017-04-07 16:10 +0200
        Re: tty crash in tty_ldisc_receive_buf() Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-04-08 01:30 +0200
  Re: tty crash in tty_ldisc_receive_buf() Wang YanQing <udknight@gmail.com> - 2017-04-07 03:30 +0200
    Re: tty crash in tty_ldisc_receive_buf() Michael Neuling <mikey@neuling.org> - 2017-04-07 04:10 +0200

csiph-web