Re: [PATCH] fpga fr br: fix warning for unexpected version number

From	Moritz Fischer <mdf@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fpga fr br: fix warning for unexpected version number
Date	2017-04-06 02:20 +0200
Message-ID	<tt3jz-18Z-1@gated-at.bofh.it> (permalink)
References	<tsYtA-6BL-19@gated-at.bofh.it> <tsZzj-7hF-1@gated-at.bofh.it> <tt1B7-8sp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Matthew,

On Wed, Apr 5, 2017 at 3:25 PM,  <matthew.gerlach@linux.intel.com> wrote:

>> Maybe you actually wanna bail out if you read a random other value
>> instead of what you
>> expect instead of printing a warning.
>
>
> I thought about making it an error if the version didn't match, but it was a
> dev_warn() before and that allowed folks to use the "old" driver with the
> new IP version.

Or some random other piece of logic in the FPGA that happens to be mapped
to that address ;-)

I agree we should've probably caught this in the initial review, but maybe we
should change it.

Cheers,

Moritz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fpga fr br: fix warning for unexpected version number matthew.gerlach@linux.intel.com - 2017-04-05 21:10 +0200
  Re: [PATCH] fpga fr br: fix warning for unexpected version number Moritz Fischer <mdf@kernel.org> - 2017-04-05 22:20 +0200
    Re: [PATCH] fpga fr br: fix warning for unexpected version number matthew.gerlach@linux.intel.com - 2017-04-06 00:30 +0200
      Re: [PATCH] fpga fr br: fix warning for unexpected version number Moritz Fischer <mdf@kernel.org> - 2017-04-06 02:20 +0200

csiph-web